-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aabb2d #355
aabb2d #355
Conversation
@duarm thanks for the PR,
I couldn't see any.
That would be nice 👍 |
@duarm ping. |
I've added a new I'm using these functions on my project, and might add more later, along with the tests since I'm a little busy, if someone doesn't do it before me |
@duarm thanks 👍 |
You might want to review this and merge if you want, before the new release. Mark as experimental or something like that, since there are no tests (box.h also doesnt have tests). I can open a new PR for more functions and tests. |
Sure thanks, we can merge this and get |
include/cglm/aabb2d.h
Outdated
*/ | ||
CGLM_INLINE | ||
bool | ||
glm_aabb2d_frustum(vec2 aabb[2], vec4 planes[6]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you dont use this, maybe we should remove this func for now and bring back when it is well defined. Because frustum is 3D, since there is no Z here intersection could only be done with two axes e.g. far & near planes or sum of them ...
Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should remove this for now, just renamed the function and removed the z axis, I'm not using it, we can add it back if someone needs it
@duarm many thanks, the PR is merged 🚀 additional fixes, improvements can be done with another PRs |
aabb2d functionality, just renamed every box.h procedure + documentation, for now. Closes #349
TODO
_sphere
->_circle
_copy
Namespace
_aabb2d_
?_aabb2_
?