ivec += and -= functions #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BeeverFeever many thanks, looks good, waiting for other types 👍 |
|
@BeeverFeever ping. |
|
@recp Hey, sorry for the wait. I havent been home for a while so I havent been able to do anything. Im getting home tomorrow today though. I should be able to have it almost done by tomorrow. |
|
@BeeverFeever thanks 🤗 |
|
@recp Just finished them (atleast I think everything is done). |
|
@BeeverFeever many thanks for your contributions, the PR is merged 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@recp This first commit is purely just to make sure the format and style is what you were thinking of for the ivec functions. I noticed the += family of functions weren't even there so I implemented them as well. This is all I have done, I haven't bothered with tests yet, I am just seeking your feedback on any details before I implement them for ivec3 and ivec4 (and also finish ivec2). There may be errors in here but I will read over it all when I polish it up.