Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with difference in ansible yum output. #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dvalinrh
Copy link
Contributor

Issue #133

Problem Description

The ansible yum module is returning different contents in the status register when failing on a a straight package install versus "@development Tools". The later yum operation when returning an error does not contain the variable "rc" in the status register, and results in the playbook terminating on syntax and not cleaning up any of the outstanding clouds.

Solution

  1. Remove checking the status value set via ansible yum module.
  2. Use a rescue block in the role "install_packages" to handle when the yum module fails.
  3. In ten_of_us
    • download the yum install status file, and check to see if we have failed.
    • remove duplicate install_status check
    • Always check the install status, regardless if local system or other.

@dvalinrh dvalinrh requested a review from a team December 17, 2024 16:04
- name: Report Success
lineinfile:
path: "{{ results_file }}"
line: "status: sucess"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member

@kdvalin kdvalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve once the typo is addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants