Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC: Enhance throughput section #1043

Merged
merged 12 commits into from
Jan 22, 2025
Merged

RC: Enhance throughput section #1043

merged 12 commits into from
Jan 22, 2025

Conversation

cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Jan 10, 2025

DOC-4709

@NoamSternRedis I took your draft and kept the same points while also making it more concise and fit our style. If you think anything's missing, let me know.

@cmilesb cmilesb requested review from NoamSternRedis and a team January 10, 2025 16:48
@cmilesb cmilesb self-assigned this Jan 10, 2025
@cmilesb cmilesb added the rc Redis Cloud docs label Jan 10, 2025
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cmilesb cmilesb requested review from a team and dwdougherty January 14, 2025 15:11
### Throughput factors and variability

The following factors can affect your database's throughput:
- **Request size**: Smaller requests (under 3KB) consume less network bandwidth and may result in more operations per second than requested, while larger requests may result in fewer operations per second.
Copy link
Contributor

@NoamSternRedis NoamSternRedis Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmilesb, do you think it's enough that under 3KB, you might get more operations? the parenthesis location makes the sentence not that clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clear enough. @mich-elle-luna can you sanity check me on this?

content/operate/rc/databases/configuration/sizing.md Outdated Show resolved Hide resolved
content/operate/rc/databases/configuration/sizing.md Outdated Show resolved Hide resolved
content/operate/rc/databases/configuration/sizing.md Outdated Show resolved Hide resolved
content/operate/rc/databases/configuration/sizing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kaitlynmichael kaitlynmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some super small wording suggestions

content/operate/rc/databases/configuration/sizing.md Outdated Show resolved Hide resolved
content/operate/rc/databases/configuration/sizing.md Outdated Show resolved Hide resolved
content/operate/rc/databases/configuration/sizing.md Outdated Show resolved Hide resolved
Change "Scalability" section to "Performance" section
@cmilesb cmilesb merged commit a491840 into main Jan 22, 2025
5 checks passed
@cmilesb cmilesb deleted the DOC-4709 branch January 22, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rc Redis Cloud docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants