-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC: Enhance throughput section #1043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
### Throughput factors and variability | ||
|
||
The following factors can affect your database's throughput: | ||
- **Request size**: Smaller requests (under 3KB) consume less network bandwidth and may result in more operations per second than requested, while larger requests may result in fewer operations per second. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmilesb, do you think it's enough that under 3KB, you might get more operations? the parenthesis location makes the sentence not that clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clear enough. @mich-elle-luna can you sanity check me on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left some super small wording suggestions
Co-authored-by: Kaitlyn Michael <[email protected]>
Change "Scalability" section to "Performance" section
DOC-4709
@NoamSternRedis I took your draft and kept the same points while also making it more concise and fit our style. If you think anything's missing, let me know.