-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4753 added RDI upgrade guide #1089
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor recommendation. Otherwise, LGTM.
|
||
### Recovering from failure during a Kubernetes upgrade | ||
|
||
If you get an error during the upgrade or some deployments are not OK, then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If OK here is referring to a state shown in a command's output, then using OK is okay. :) Otherwise, use okay. This is not a Google style guide issue per se (it uses both OK and okay to mean the latter), but I've seen this rule on other style guides. Up to you.
|
||
### Recovering from failure during a VM upgrade | ||
|
||
If the previous version is v1.4.4 or later, go to the `rdi_install/<NEW_VERSION>` directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake, it's not the NEW_VERSION, it's the previous version
|
||
{{< note >}}If the `collector-source` or the `processor` are not in the `Running` state during | ||
the upgrade, you must run `redis-di deploy` and check again that they are both in the | ||
`Running` state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaronp68 is it clear that the command should be run after the downgrade?
[deploy]({{< relref "/integrate/redis-data-integration/data-pipelines/deploy" >}}) | ||
again after this step. | ||
|
||
1. Download the latest `redis-di`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaronp68 can we remove it? They don't need it for the k8s installation.
docker pull redis/rdi-operator:tagname | ||
docker pull redis/rdi-api:tagname | ||
docker pull redis/rdi-monitor:tagname | ||
docker pull redis/rdi-collector-initializer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaronp68 what about the collector-api?
DOC-4753 (based on this Confluence page).
Is there any more to add to this before merging? Also, the K8s installation section says that you should download
redis-di
- can you actually download this separately?