DEV: change sub-title on JSON main page #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-stark-redis
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Well... I think the product name is Redis JSON and there's an "Enable Redis JSON" heading lower in the page. A bit 50/50 but I agree that it probably looks better to introduce it like this; "Enable Redis JSON" refers to the module of that name, but this section doesn't. Anyway, approved.
|
Thanks Andy. I agree that what's here now is just as awkward as what was there before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.