feat(web): add example of show selected features information in plugin playground #1376
Conversation
…information-in-plugin-playground
|
Warning Rate limit exceeded@ShogoHirasawa has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 51 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request introduces a new plugin called Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
web/src/beta/features/PluginPlayground/Plugins/presets/layers/showSelectedFeaturesInformation.ts (5)
46-46: Fix HTML structure.There's an orphaned closing
</p>tag without a corresponding opening tag.- <span id="message" class="displayId"></span></p> + <span id="message" class="displayId"></span>
50-57: Enhance message handling robustness.The message handling could be more robust by:
- Validating the message origin
- Adding error handling for missing elements
window.addEventListener('message', function(e) { + // Validate message origin + if (e.source !== parent) return; + if (e.data?.action === "buildingClick") { const gmlId = e.data.payload?.gmlId || ""; const messageEl = document.getElementById("message"); + if (!messageEl) { + console.error("Message element not found"); + return; + } messageEl.textContent = gmlId; } });
65-76: Consider making the tileset URL configurable.The tileset URL is hardcoded, which could make it difficult to:
- Switch between different PLATEAU datasets
- Handle URL changes or migrations
- Support different environments (development, staging, production)
Consider making this configurable through plugin settings or environment variables.
Also, please add documentation for the 3D tiles configuration options to improve maintainability.
78-102: Add error handling for layer setup and improve camera configuration.
- Add error handling for layer addition
- Consider making camera position configurable or document why these specific coordinates are used
// Add the 3D Tiles layer from the URL to Re:Earth -reearth.layers.add(layer3dTiles); +try { + reearth.layers.add(layer3dTiles); +} catch (error) { + console.error("Failed to add 3D Tiles layer:", error); +} +// Camera position for Minato-ku, Tokyo reearth.camera.flyTo( { heading: 4.022965234428543,
104-126: Add error handling for feature lookup.The feature selection handling looks good, but could benefit from additional error handling for the feature lookup.
// Get information about the selected building (feature) - const feature = reearth.layers.findFeatureById(layerId, featureId); + let feature; + try { + feature = reearth.layers.findFeatureById(layerId, featureId); + } catch (error) { + console.error("Failed to find feature:", error); + reearth.ui.postMessage({ + action: "buildingClick", + payload: { gmlId: "", error: "Failed to fetch feature information" }, + }); + return; + }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
web/src/beta/features/PluginPlayground/Plugins/presets/index.ts(2 hunks)web/src/beta/features/PluginPlayground/Plugins/presets/layers/showSelectedFeaturesInformation.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: ci-server / ci-server-lint
- GitHub Check: ci-web / ci
- GitHub Check: ci-server / ci-server-test
🔇 Additional comments (3)
web/src/beta/features/PluginPlayground/Plugins/presets/index.ts (1)
15-15: LGTM! Plugin integration looks good.The new plugin is correctly imported and integrated into the layers category of preset plugins.
Also applies to: 61-62
web/src/beta/features/PluginPlayground/Plugins/presets/layers/showSelectedFeaturesInformation.ts (2)
4-23: LGTM! Plugin configuration is well-structured.The YAML configuration appropriately defines the widget layout and metadata.
129-133: LGTM! Plugin export is correctly structured.The plugin is exported with the appropriate type and includes all necessary files.
…nformation-in-plugin-playground
| widgetLayout: | ||
| defaultLocation: | ||
| zone: outer | ||
| section: center | ||
| area: top |
There was a problem hiding this comment.
| widgetLayout: | |
| defaultLocation: | |
| zone: outer | |
| section: center | |
| area: top |
Better remove this part unless current plugin requires any certain location.
Overview
This is PR for adding Plugin Playgroung example.
What I've done
What I haven't done
How I tested
I have tested in my local environment.
Which point I want you to review particularly
Memo
Summary by CodeRabbit
showFeaturesInfoplugin option.