Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout and navbar; remove unused svgs #13

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

naconnors
Copy link
Contributor

@naconnors naconnors commented May 5, 2023

Description

Setup Layout and NavBar components

GitHub Issue: [Resolves] #12

Changes

  • Add NavBar component
  • Add Layout component
  • Add Layout component to _app.tsx so that it is displayed on all pages

Testing Strategy

Run according to instructions in README. Test links in navbar.

Concerns

Additional work should be done to make it more responsive. RNS logo could be added in the navbar somewhere.

@naconnors naconnors added the enhancement New feature or request label May 5, 2023
@jhodapp jhodapp added this to the 0.5.0 milestone May 26, 2023
@jhodapp jhodapp requested review from qafui and jhodapp May 26, 2023 00:14
@jhodapp jhodapp merged commit 7e966b7 into main Jun 16, 2023
@qafui qafui deleted the 12-add-navigation-bar branch June 20, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants