Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return websocket protocol when asked #4683

Merged
merged 1 commit into from
Jan 23, 2025
Merged

return websocket protocol when asked #4683

merged 1 commit into from
Jan 23, 2025
+26 −2

Conversation

adhami3310
Copy link
Member

No description provided.

masenf
masenf approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see the env.TEST_MODE hacks continuing to be useful?

My inclination is to remove the whole mechanism to avoid cases in the future where we special case our integration tests and end up actually hiding issues.

@adhami3310
Copy link
Member Author

Do you see the env.TEST_MODE hacks continuing to be useful?

good point, i'm not sure, i could perceive it to be useful considering we haven't switched off to pyright completely, so some tests might need it

@adhami3310 adhami3310 merged commit abc9038 into main Jan 23, 2025
37 checks passed
@adhami3310 adhami3310 deleted the return-websocket-protocol-when-asked branch January 23, 2025 23:10
@adhami3310 adhami3310 mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @masenf