Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure logger debug calls always return true #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gugaiz
Copy link

@gugaiz gugaiz commented Nov 28, 2024

Issue #304

Description of changes

Modify logger debug behavior to return true regardless of the log level, ensuring dependent processes like state machines in solidus function correctly

Context

In Rails’ default logger, a call to logger.debug always returns true regardless of the log level, preserving compatibility with code that relies on the return value. However, rails_semantic_logger deviates from this behavior, returning false when the log level does not allow the message to be logged. This discrepancy can cause unexpected issues in frameworks like Solidus or other applications using state machines or similar logic.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Modify logger debug behavior to return true regardless of the log level, ensuring dependent processes like state machines in solidus function correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant