Mirror write WIP #775
Open
Mirror write WIP #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exodus_gw/worker/publish.py
Outdated
| @property | ||
| def should_mirror_writes(self): | ||
| print() | ||
| return False |
There was a problem hiding this comment.
Shouldn't the overridden should_mirror_writes property with the explicit return False statement exist in CommitPhase2, not CommitPhase1?
There was a problem hiding this comment.
The existing values should've been the other way around. I don't know when they got switched 😖
I'm imagining some future where we add another commit phase. I think it's more likely we'll keep mirroring to phase 1, so having False be the default case for a commit phase class feels right
amcmahon-rh
force-pushed
the
mirror_writes
branch
from
cd0ec0b to
122d916
Compare
for more information, see https://pre-commit.ci
|
Looks good so far! Could you please add a few tests to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.