Change GP training Rust API to use one dimensional array #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Array1 as dataset training output and predict output instead of Array2
Accept 1d training inputs/outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the GP Rust API types mimicked the SMT ones using 2D arrays (
Array2) for output training data. Actually the impplementation handles correctly only one-dimensional output waiting for [nsamples, 1] array (column vector).This PR enforces the correctness on Rust side by using
Array1for training output data.The GP Rust training API is now like:
fit(xt: Array2<f64>, yt: Array1<f64>)As far the Python API is concerned, we still accept column vectors but we now also accept one-dimensional ndarray.
See background in #218 and also in SMTorg/smt#679