Refactor editable attributes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
simon-isler
force-pushed
the
feature/editable-attributes
branch
from
06a01cf to
316fcd9
Compare
simon-isler
commented
Nov 12, 2024
simon-isler
force-pushed
the
feature/editable-attributes
branch
from
b882609 to
9661987
Compare
simon-isler
force-pushed
the
feature/validate-config
branch
from
e7bc0af to
670f80c
Compare
simon-isler
force-pushed
the
feature/editable-attributes
branch
from
9661987 to
558854d
Compare
simon-isler
force-pushed
the
feature/editable-attributes
branch
from
a804d7c to
1742d22
Compare
simon-isler
force-pushed
the
feature/editable-attributes
branch
from
1742d22 to
c4216da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18
out of #30 (comment):
I don't really like how we define the editable_attributes so far. IMO there is no need to define it on existing models. I'd prefer a module with a method that returns the editable attributes for a model. This will make it also easier to test, which is essential since this logic is where everything starts :)