Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-90473 || Retention important launch #1988

Merged
merged 3 commits into from
May 8, 2024

Conversation

IvanKustau
Copy link
Contributor

No description provided.

@IvanKustau IvanKustau self-assigned this May 8, 2024
@IvanKustau IvanKustau requested a review from avarabyeu as a code owner May 8, 2024 08:49
import java.util.Set;
import org.springframework.stereotype.Component;

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
First sentence of Javadoc is missing an ending period.

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

public class AttributeHandlerTest {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

extractProjectDetails(rpUser, "test_project"),
startLaunchRQ
);
final StartLaunchRS startLaunchRS =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'startLaunchRS' must contain no more than '1' consecutive capital letters.

@IvanKustau IvanKustau merged commit 8e6c5b5 into develop May 8, 2024
7 checks passed
@IvanKustau IvanKustau deleted the EPMRPP-90473-retention-important-launch branch May 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants