5.13.0 Release #2117
5.13.0 Release #2117
Conversation
EPMRPP-89095 || Add new scim related fields
EPMRPP-92655 || Add request for creating empty user for identity
EPMRPP-92655 || Add custom email template for identity users.
Update Dockerfile
# Conflicts: # build.gradle
EPMRPP-93398 || Update getting project endpoint
EPMRPP-95243 || Update scim related fileds
EPMRPP-96070 || Provide uuid on user replication by default in db
EPMRPP-96070 || Add default fields to user builder
Update imports and dependencies
EPMRPP-97471 || Added old representation of date in launch and item
changed runs-on
EPMRPP-96618 || Update the link on tutorial in invitation emails
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
reviewdog
src/main/java/com/epam/ta/reportportal/ws/controller/TestItemController.java|248 col 3| '@' has incorrect indentation level 2, expected level should be 6.
src/main/java/com/epam/ta/reportportal/ws/controller/TestItemController.java|339 col 3| '@' has incorrect indentation level 2, expected level should be 6.
src/main/java/com/epam/ta/reportportal/ws/controller/TestItemController.java|342 col 3| '@' has incorrect indentation level 2, expected level should be 6.
src/main/java/com/epam/ta/reportportal/ws/controller/TestItemController.java|345 col 3| '@' has incorrect indentation level 2, expected level should be 6.
src/main/java/com/epam/ta/reportportal/ws/converter/converters/LaunchConverter.java|101 col 54| Abbreviation in name 'TO_RESOURCE_OLD' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/ta/reportportal/ws/converter/converters/LaunchConverter.java|101 col 54| Member name 'TO_RESOURCE_OLD' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
src/main/java/com/epam/ta/reportportal/ws/converter/converters/ServerSettingsConverter.java|37| Line is longer than 100 characters (found 130).
src/main/java/com/epam/ta/reportportal/ws/converter/converters/ServerSettingsConverter.java|40| Line is longer than 100 characters (found 108).
src/main/java/com/epam/ta/reportportal/ws/converter/converters/TestItemConverter.java|96| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/ws/controller/LaunchControllerTest.java|144| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/controller/LaunchControllerTest.java|153| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java|104 col 18| Abbreviation in name 'createUserRS' must contain no more than '1' consecutive capital letters.
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java|298 col 16| Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java|307 col 16| Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java|316 col 16| Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java|325 col 16| Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java|334 col 16| Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
src/test/java/com/epam/ta/reportportal/ws/controller/UserControllerTest.java|343 col 16| Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
| @@ -42,4 +43,12 @@ public interface ServerAdminHandler { | |||
| * @return Operation results | |||
| */ | |||
| OperationCompletionRS saveAnalyticsSettings(AnalyticsResource analyticsResource); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
First sentence of Javadoc is missing an ending period.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.epam.ta.reportportal.core.events.activity; |
There was a problem hiding this comment.
'package' should be separated from previous line.
| import com.epam.ta.reportportal.entity.activity.EventSubject; | ||
| import com.epam.ta.reportportal.model.settings.ServerSettingsResource; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Summary javadoc is missing.
| /** | ||
| * @author <a href="mailto:[email protected]">Pavel Bortnik</a> | ||
| */ | ||
| public class SettingsUpdatedEvent extends AroundEvent<ServerSettingsResource> implements ActivityEvent { |
There was a problem hiding this comment.
Line is longer than 100 characters (found 104).
| */ | ||
| public class SettingsUpdatedEvent extends AroundEvent<ServerSettingsResource> implements ActivityEvent { | ||
|
|
||
| public SettingsUpdatedEvent(ServerSettingsResource before, ServerSettingsResource after, Long userId, |
There was a problem hiding this comment.
Line is longer than 100 characters (found 103).
| @@ -378,6 +404,31 @@ | |||
| ); | |||
| } | |||
|
|
|||
| @Transactional | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| description = "Successful response with dates in timestamp format. " | ||
| + "Response with dates in ISO-8601 format if the custom header " | ||
| + "'Accept: application/x.reportportal.launch.v2+json' is used.", | ||
| content = @Content(mediaType = "application/json", schema = @Schema(implementation = LaunchResourceOld.class)) |
There was a problem hiding this comment.
Line is longer than 100 characters (found 116).
| ) | ||
| public LaunchResourceOld mergeLaunchesOldUuid(@PathVariable String projectName, | ||
| @Parameter(description = "Merge launches request body", required = true) @RequestBody | ||
| @Validated MergeLaunchesRQ mergeLaunchesRQ, @AuthenticationPrincipal ReportPortalUser user) { |
There was a problem hiding this comment.
Abbreviation in name 'mergeLaunchesRQ' must contain no more than '1' consecutive capital letters.
|
|
||
| @Transactional(readOnly = true) |
There was a problem hiding this comment.
Missing a Javadoc comment.
| description = "Successful response with dates in timestamp format. " | ||
| + "Response with dates in ISO-8601 format if the custom header " | ||
| + "'Accept: application/x.reportportal.test.v2+json' is used.", | ||
| content = @Content(mediaType = "application/json", schema = @Schema(implementation = TestItemResourceOld.class)) |
There was a problem hiding this comment.
Line is longer than 100 characters (found 118).
| .content(objectMapper.writeValueAsBytes(rq))).andExpect(status().isCreated()) | ||
| .andReturn(); | ||
|
|
||
| CreateUserRS createUserRS = objectMapper.readValue(mvcResult.getResponse().getContentAsString(), |
There was a problem hiding this comment.
Abbreviation in name 'createUserRS' must contain no more than '1' consecutive capital letters.
| @@ -256,6 +293,60 @@ | |||
| .content(objectMapper.writeValueAsBytes(editUserRQ))).andExpect(status().isOk()); | |||
| } | |||
|
|
|||
| @Test | |||
| void editAccountTypeByAdmin() throws Exception { | |||
| EditUserRQ editUserRQ = new EditUserRQ(); | |||
There was a problem hiding this comment.
Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
|
|
||
| @Test | ||
| void editAccountTypeByAdminNegative() throws Exception { | ||
| EditUserRQ editUserRQ = new EditUserRQ(); |
There was a problem hiding this comment.
Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
|
|
||
| @Test | ||
| void editActiveByAdmin() throws Exception { | ||
| EditUserRQ editUserRQ = new EditUserRQ(); |
There was a problem hiding this comment.
Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
|
|
||
| @Test | ||
| void editAccountTypeByNotAdmin() throws Exception { | ||
| EditUserRQ editUserRQ = new EditUserRQ(); |
There was a problem hiding this comment.
Abbreviation in name 'editUserRQ' must contain no more than '1' consecutive capital letters.
| @@ -97,6 +98,30 @@ | |||
| return resource; | |||
| }; | |||
|
|
|||
| public Function<LaunchResource, LaunchResourceOld> TO_RESOURCE_OLD = resource -> { | |||
There was a problem hiding this comment.
Member name 'TO_RESOURCE_OLD' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
| @@ -238,13 +245,14 @@ public OperationCompletionRS handleSuggestChoose(@PathVariable String projectNam | |||
| @Schema(implementation = TestItemHistoryElement.class) | |||
| public Iterable<TestItemResource> getTestItems(@PathVariable String projectName, | |||
| @AuthenticationPrincipal ReportPortalUser user, @Nullable | |||
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ + CRITERIA_LAUNCH_ID, required = false) | |||
| Long launchId, | |||
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ | |||
There was a problem hiding this comment.
'@' has incorrect indentation level 2, expected level should be 6.
| Long itemId, @Nullable | ||
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ + CRITERIA_LAUNCH_ID, required = false) | ||
| Long launchId, @Nullable @RequestParam(value = HISTORY_TYPE_PARAM, required = false) String type, | ||
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ |
There was a problem hiding this comment.
'@' has incorrect indentation level 2, expected level should be 6.
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ | ||
| + CRITERIA_PARENT_ID, required = false) | ||
| Long parentId, @Nullable | ||
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ |
There was a problem hiding this comment.
'@' has incorrect indentation level 2, expected level should be 6.
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ | ||
| + CRITERIA_ID, required = false) | ||
| Long itemId, @Nullable | ||
| @Parameter(hidden = true) @RequestParam(value = DEFAULT_FILTER_PREFIX + Condition.EQ |
There was a problem hiding this comment.
'@' has incorrect indentation level 2, expected level should be 6.
No description provided.