Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade esbuild #1817

Merged
merged 4 commits into from
Jan 22, 2025
Merged

chore: upgrade esbuild #1817

merged 4 commits into from
Jan 22, 2025

Conversation

LucianBuzzo
Copy link
Contributor

My motivation for this PR is to fix a security warning for CVE-2024-24790 that comes from the underlying Go version used by esbuild.
Upgrading to v0.22.0 drops support for node versions older than v18, which isn't a problem for this project, but it also drops support for the follow operating systems:

  • Windows 7
  • Windows 8
  • Windows Server 2008
  • Windows Server 2012

For more details see https://github.com/evanw/esbuild/releases/tag/v0.22.0

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 67e634b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024

@LucianBuzzo is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

Pehesi97
Pehesi97 reviewed Dec 18, 2024
View reviewed changes
Copy link

@Pehesi97 Pehesi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should impact positively in many projects out there. Looking forward to getting this merged

packages/react-email/package.json Outdated Show resolved Hide resolved
@gabrielmfern gabrielmfern force-pushed the canary branch 2 times, most recently from 4ee4d1d to 0187b0a Compare December 23, 2024 13:28
@gabrielmfern gabrielmfern force-pushed the canary branch 2 times, most recently from bf3f899 to 1748335 Compare January 13, 2025 16:13
@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from d36385e to 7e7c5b0 Compare January 22, 2025 12:41
dependabot bot and others added 2 commits January 22, 2025 09:48
@dependabot @gabrielmfern
chore(deps): bump next from 14.2.3 to 15.0.4 (resend#1810)
0f5fcb2 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LucianBuzzo @gabrielmfern
feat: upgrade to esbuild v0.22.0
b6e6922
@gabrielmfern gabrielmfern force-pushed the lucianbuzzo/upgrade-esbuild-0.22.x branch from 091193e to b6e6922 Compare January 22, 2025 12:49
@gabrielmfern gabrielmfern changed the title feat: upgrade to esbuild v0.22.0 chore: upgrade esbuild Jan 22, 2025
@gabrielmfern
Copy link
Collaborator

Updated it to use esbuild 0.23.0 as it seems like 0.22.0 temporarily changed a behavior that breaks the Preview Server's rendering

@gabrielmfern gabrielmfern merged commit ba12dcc into resend:canary Jan 22, 2025
4 of 6 checks passed
gabrielmfern added a commit that referenced this pull request Jan 22, 2025
@LucianBuzzo @dependabot @gabrielmfern
chore: upgrade esbuild (#1817)
12d007e 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pehesi97 Pehesi97 Pehesi97 left review comments

@gabrielmfern gabrielmfern gabrielmfern approved these changes

@Sr-santi Sr-santi Sr-santi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucianBuzzo @gabrielmfern @Pehesi97 @Sr-santi