-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tailwind): extract pseudo classes to stylesheet #1864
base: canary
Are you sure you want to change the base?
feat(tailwind): extract pseudo classes to stylesheet #1864
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 1d9227a The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Sjoertjuh is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
9a66e12
to
fe2573d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, really nice! We planned on having this at some point, so this is really helpful!
One thing that still needs an adjustment is when the user has a media query with pseudo selectors as well, I also added in a change in the tests that currently fails to ensure that this works.
Another thing I'd like improvement is the duplicated code between the sanitization of media queries and of the pseudo selectors, since they seem to be mostly the same.
I indeed forgot that you could mix media queries with pseudo classes, so I added that. Also the change in the test was not completely correct, so that is updated as well. |
9b6098c
to
ee6d8fb
Compare
Solves the following discussion: #1338
This extracts pseudo classes like
:hover
to the stylesheet.