Remove JavaErrorsTest#propagate404 as it doesn't make sense anymore…

… with restatedev/restate#495 (#147)
restatedev · Jun 21, 2023 · e8094a9 · e8094a9
1 parent 7500361
commit e8094a9
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 38 deletions.
diff --git a/contracts/src/main/proto/errors.proto b/contracts/src/main/proto/errors.proto
@@ -13,7 +13,6 @@ service FailingService {
   rpc Fail (ErrorMessage) returns (google.protobuf.Empty);
   rpc FailAndHandle (ErrorMessage) returns (ErrorMessage);
   rpc InvokeExternalAndHandleFailure(FailRequest) returns (ErrorMessage);
-  rpc HandleNotFound (FailRequest) returns (ErrorMessage);
 }
 
 message FailRequest {

diff --git a/services/java-services/src/main/java/dev/restate/e2e/services/errors/FailingService.java b/services/java-services/src/main/java/dev/restate/e2e/services/errors/FailingService.java
@@ -1,14 +1,12 @@
 package dev.restate.e2e.services.errors;
 
 import com.google.protobuf.Empty;
-import com.google.rpc.Code;
 import dev.restate.e2e.services.errors.ErrorsProto.ErrorMessage;
 import dev.restate.e2e.services.errors.ErrorsProto.FailRequest;
 import dev.restate.e2e.services.utils.NumberSortHttpServerUtils;
 import dev.restate.sdk.blocking.Awakeable;
 import dev.restate.sdk.blocking.RestateBlockingService;
 import dev.restate.sdk.core.TypeTag;
-import io.grpc.MethodDescriptor;
 import io.grpc.Status;
 import io.grpc.StatusRuntimeException;
 import io.grpc.stub.StreamObserver;
@@ -95,26 +93,4 @@ public void invokeExternalAndHandleFailure(
     responseObserver.onNext(ErrorMessage.newBuilder().setErrorMessage(finalMessage).build());
     responseObserver.onCompleted();
   }
-
-  @Override
-  public void handleNotFound(FailRequest request, StreamObserver<ErrorMessage> responseObserver) {
-    var methodDescriptor =
-        FailingServiceGrpc.getFailMethod().toBuilder()
-            .setFullMethodName(
-                MethodDescriptor.generateFullMethodName(
-                    FailingServiceGrpc.SERVICE_NAME, "UnknownFn"))
-            .build();
-    try {
-      restateContext().call(methodDescriptor, ErrorMessage.getDefaultInstance()).await();
-    } catch (StatusRuntimeException e) {
-      if (e.getStatus().getCode().value() == Code.NOT_FOUND_VALUE) {
-        responseObserver.onNext(ErrorMessage.newBuilder().setErrorMessage("notfound").build());
-        responseObserver.onCompleted();
-      } else {
-        throw new IllegalStateException("Got unexpected error: " + e.getMessage());
-      }
-    }
-
-    throw new IllegalStateException("This should be unreachable");
-  }
 }
diff --git a/services/node-services/src/errors.ts b/services/node-services/src/errors.ts
@@ -42,7 +42,4 @@ export class FailingService implements IFailingService {
   invokeExternalAndHandleFailure(): Promise<ErrorMessage> {
     throw new Error("Method not implemented.");
   }
-  handleNotFound(): Promise<ErrorMessage> {
-    throw new Error("Method not implemented.");
-  }
 }
diff --git a/tests/src/test/kotlin/dev/restate/e2e/ErrorsTest.kt b/tests/src/test/kotlin/dev/restate/e2e/ErrorsTest.kt
@@ -49,16 +49,6 @@ class JavaErrorsTest : BaseErrorsTest() {
         .extracting(ErrorMessage::getErrorMessage)
         .isEqualTo("begin:external_call:internal_call")
   }
-
-  @DisplayName("Test calling unknown service method from within another service")
-  @Test
-  fun propagate404(@InjectBlockingStub stub: FailingServiceBlockingStub) {
-    assertThat(
-            stub.handleNotFound(
-                FailRequest.newBuilder().setKey(UUID.randomUUID().toString()).build()))
-        .extracting(ErrorMessage::getErrorMessage)
-        .isEqualTo("notfound")
-  }
 }
 
 class NodeErrorsTest : BaseErrorsTest() {