Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not entirely clear to me what was causing the previous logging implementation to have issues. Only logs with
MessageType::ERROR
would be logged (at least in neovim). This could be partially addressed by using atracing_subscriber
logger (as suggested here: ebkalderon/tower-lsp#423). The server's logs would show up if the level was set toTRACE
, but then so would every single message exchanged between the lsp client and server. Swapping out the calls toself.client.log_message()
with thelog
crate's macros, as well as to thetracing_subscriber
changes seems to remedy things. Log file after start up: