Codec fix #33
Merged
Codec fix #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was not always very clear what the last argument that the xmerl_sax_parser returned was. After more investigation its any remaing characters after the closing element. In some tests this could show up as newlines or other stuff we dont care about.
The tests never got updated when the move from just having a parse function to having both parse and from_file. Fix tests and added small test for new parse function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests never got updated when the move from just having a parse
function to having both parse and from_file. Fix tests and added small
test for new parse function
I am going to put in some work to get a test pipeline up and running in this repo. I am just too used to having a test pipeline that runs and saves my butt. I am pushing a lot of broken tests lately!