fix test/linting/typescript

ripple · Dec 17, 2024 · 8f4ac3a · 8f4ac3a
1 parent 10f822d
commit 8f4ac3a
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 42 deletions.
diff --git a/src/containers/Token/DEXPairs/index.tsx b/src/containers/Token/DEXPairs/index.tsx
@@ -169,9 +169,7 @@ export const DEXPairs = ({ accountId, currency }: DexPairsProps) => {
         <table>
           <thead>
             <tr>
-              <th className="pair-header" className="left-align">
-                {t('pair')}
-              </th>
+              <th className="pair-header">{t('pair')}</th>
               <th>{t('issuer')}</th>
               <th className="stats-header">{t('offer_range')}</th>
             </tr>

diff --git a/src/containers/Token/TokenHeader/index.tsx b/src/containers/Token/TokenHeader/index.tsx
@@ -1,5 +1,4 @@
 import { useTranslation } from 'react-i18next'
-import { Loader } from '../../shared/components/Loader'
 import './styles.scss'
 import { localizeNumber, formatLargeNumber } from '../../shared/utils'
 import Currency from '../../shared/components/Currency'
@@ -130,7 +129,7 @@ export const TokenHeader = ({
       CURRENCY_OPTIONS,
     )
     const obligationsBalance = formatLargeNumber(
-      Number.parseFloat(obligations || 0),
+      Number.parseFloat(obligations || '0'),
     )
 
     return (

diff --git a/src/containers/Token/index.tsx b/src/containers/Token/index.tsx
@@ -48,7 +48,7 @@ const Page: FC<PropsWithChildren<{ accountId: string }>> = ({
   </div>
 )
 
-export const Token: FC<{ error: string }> = () => {
+export const Token = () => {
   const rippledSocket = useContext(SocketContext)
   const { trackScreenLoaded } = useAnalytics()
   const { token = '' } = useRouteParams(TOKEN_ROUTE)
@@ -88,11 +88,13 @@ export const Token: FC<{ error: string }> = () => {
       {isTokenDataLoading ? (
         <Loader />
       ) : (
-        <TokenHeader
-          accountId={accountId}
-          currency={currency}
-          data={tokenData}
-        />
+        tokenData && (
+          <TokenHeader
+            accountId={accountId}
+            currency={currency}
+            data={tokenData}
+          />
+        )
       )}
       {accountId && tokenData && IS_MAINNET && (
         <DEXPairs accountId={accountId} currency={currency} />

diff --git a/src/containers/Token/test/index.test.tsx b/src/containers/Token/test/index.test.tsx
@@ -1,33 +1,32 @@
 import { mount } from 'enzyme'
-import configureMockStore from 'redux-mock-store'
-import thunk from 'redux-thunk'
-import { Provider } from 'react-redux'
 import { Route } from 'react-router-dom'
-import { initialState } from '../../../rootReducer'
 import i18n from '../../../i18n/testConfig'
-import Token from '../index'
-import TokenHeader from '../TokenHeader'
+import { Token } from '../index'
+import { TokenHeader } from '../TokenHeader'
 import { TokenTransactionTable } from '../TokenTransactionTable'
-import mockAccountState from '../../Accounts/test/mockAccountState.json'
-import { QuickHarness } from '../../test/utils'
+import { flushPromises, QuickHarness } from '../../test/utils'
 import { TOKEN_ROUTE } from '../../App/routes'
+import mockAccount from '../../Accounts/test/mockAccountState.json'
+import Mock = jest.Mock
+import { getToken } from '../../../rippled'
+
+jest.mock('../../../rippled', () => ({
+  __esModule: true,
+  getToken: jest.fn(),
+}))
 
 describe('Token container', () => {
   const TEST_ACCOUNT_ID = 'rTEST_ACCOUNT'
 
-  const middlewares = [thunk]
-  const mockStore = configureMockStore(middlewares)
-  const createWrapper = (state = {}) => {
-    const store = mockStore({ ...initialState, ...state })
+  const createWrapper = (getAccountImpl = () => new Promise(() => {})) => {
+    ;(getToken as Mock).mockImplementation(getAccountImpl)
     return mount(
-      <Provider store={store}>
-        <QuickHarness
-          i18n={i18n}
-          initialEntries={[`/token/USD.${TEST_ACCOUNT_ID}`]}
-        >
-          <Route path={TOKEN_ROUTE.path} element={<Token />} />
-        </QuickHarness>
-      </Provider>,
+      <QuickHarness
+        i18n={i18n}
+        initialEntries={[`/token/USD.${TEST_ACCOUNT_ID}`]}
+      >
+        <Route path={TOKEN_ROUTE.path} element={<Token />} />
+      </QuickHarness>,
     )
   }
 
@@ -36,17 +35,10 @@ describe('Token container', () => {
     wrapper.unmount()
   })
 
-  it('renders static parts', () => {
-    const state = {
-      ...initialState,
-      accountHeader: {
-        loading: false,
-        error: null,
-        data: mockAccountState,
-      },
-    }
-
-    const wrapper = createWrapper(state)
+  it('renders static parts', async () => {
+    const wrapper = createWrapper(() => Promise.resolve(mockAccount))
+    await flushPromises()
+    wrapper.update()
     expect(wrapper.find(TokenHeader).length).toBe(1)
     expect(wrapper.find(TokenTransactionTable).length).toBe(1)
     wrapper.unmount()