fix: handling of token page throttling #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The token page is prone to being throttled because it tries to load in order books for the "top 10 tokens". This change moves logic to useQuery and out of redux. It then makes sure the token's information is loaded in before trying to load in dex pairs. Fixes #790
ckniffen
commented
Dec 17, 2024
| }) | ||
|
|
||
| it('should dispatch correct actions on successful loadTokenState', () => { | ||
| client.addResponses(rippledResponses) |
There was a problem hiding this comment.
it might be worth having this tests still to check that rippled responses are transformed right.
There was a problem hiding this comment.
We can have a ticket to add these back later.
|
Seems like #984 might be related |
pdp2121
approved these changes
Dec 17, 2024
I think we can merge this one in first to fix token page. Then we can rebase the one that you created |
anissa-ripple
approved these changes
Dec 17, 2024
endz80513
added a commit
to endz80513/explorer
that referenced
this pull request
Dec 21, 2024
This reverts commit 8d503da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The token page is prone to being throttled because it tries to load in
order books for the "top 10 tokens". This change moves logic to useQuery
and out of redux. It then makes sure the token's information is loaded
in before trying to load in dex pairs.
Fixes #790
Type of Change
TypeScript/Hooks Update
Before / After
Before
After