feat: create new dropdown menu #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinr1234
approved these changes
Apr 12, 2023
| const globalClickListener = useCallback((nativeEvent) => { | ||
| // ignore click event happened inside the dropdown menu | ||
| if (dropdownRef.current && dropdownRef.current.contains(nativeEvent.target)) | ||
| return |
There was a problem hiding this comment.
I’d suggest changing eslint (in another ticket) to not allow this style of return without curly braces.
There was a problem hiding this comment.
I could not find the rule. Do you know which one it might be?
There was a problem hiding this comment.
Define `<Dropdown>` and update `<BalanceSelector` to use it. Removing nested menu code because it is not used with current navigation and while support was defined for the desktop menu it was not for mobile in addition to the styles being very off on the desktop. Future PRs will use <Dropdown> in the header too. This will eliminate 3 menu implementations.
ckniffen
force-pushed
the
feature/new-dropdown
branch
from
2086633 to
7c1a92c
Compare
xrpl-grants
approved these changes
Apr 13, 2023
Moved BalanceSelector to its own folder.
pdp2121
approved these changes
Apr 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Define
<Dropdown>and update<BalanceSelector>to use it.Removing nested menu code because it is not used with current navigation and while support was defined for the desktop menu it was not for mobile in addition to the styles being very off on the desktop.
Future PRs will use in the header too. This will eliminate 3 menu implementations.
Context of Change
Related to #554 and a new header design.
Type of Change
TypeScript/Hooks Update
Before
After
Future Tasks
Use new component in the header