Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amendments pages styling updates #878

Merged
merged 11 commits into from
Nov 28, 2023

Conversation

pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Nov 20, 2023

High Level Overview of Change

Address #875

  • Align dropdown items in the NavBar to the left.
  • Increase font weight for the right labels of the Amendment Summary page.
  • Fix vnull issue on Amendment Summary rippled version.
  • Add an ETA to indicate the time amendment would be enabled for ones that has more than 80% votes.
  • Highlight color for amendments more than 80% on Amendments List page
  • Reduce the font size for Yays Nays to match the top of the page.
  • The y-axis of the graph should show percentage instead of count.
  • Make Enabled column all caps.
  • Rename Voters column to UNL Voters.
  • Rename Enabled (on) to Enabled on.
  • rippled version linked to rippled release for that version.
  • The details link should open a new tab.
  • Yays and Nays validators should link to the validator page on the Explorer.
  • Capitalize the labels on Validator's Voting page.
  • Fix loader timing issue on Amendments List page.
  • tx column renamed to Enable tx
  • sort to have amendments with eta on top of the amendments list

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

Before / After

Amendments List Page

Screenshot 2023-11-20 at 8 18 30 PM

Amendment Summary Page

Simple

Screenshot 2023-11-20 at 8 32 43 PM

Graph

Screenshot 2023-11-27 at 2 18 58 PM

Yeas/Nays

Screenshot 2023-11-20 at 8 33 31 PM

Validator's Voting Tab

Screenshot 2023-11-20 at 8 55 27 PM

@pdp2121 pdp2121 marked this pull request as ready for review November 21, 2023 01:44
@pdp2121 pdp2121 merged commit 5c3150e into ripple:staging Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants