Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate eigenda using hokulea library #12

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Jan 6, 2025

This is still a WIP, but opening this PR to give a sense of the approach we're thinking, to get feedback, and to see whether you guys would be willing to upstream this. I've made all eigenda code behind a feature flag, so should have 0 impact on your binary and toolings.

Our https://github.com/Layr-Labs/hokulea library is an extension to kona to support eigenda blobs.

@samlaf samlaf requested a review from hashcashier January 6, 2025 16:05
@samlaf samlaf marked this pull request as draft January 6, 2025 16:05
@hashcashier
Copy link
Collaborator

It seems like the requirements to switch over the pipeline in Kailua are quite small, which is great!

I get the goal of separating out the added functionality here, but I'm curious if you've considered multiple risc0 guest programs and no feature gating? Having the Kailua client just work out of the box w/ alt da without special build instructions sounds appealing imo.

@samlaf
Copy link
Contributor Author

samlaf commented Jan 7, 2025

@hashcashier so you mean having a separate eigenda-specific client. I had not considered that approach no. You would still need a whole separate build/run/test pipeline for that other client though. And I feel like there would be more code duplication overall than the feature-based approach? But happy to try it out if you think that could be nicer.

@hashcashier
Copy link
Collaborator

How about let's move fast and get this to a working state first however you see fit then we can discuss refinement later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants