Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKVM-910: ZIR-325: Add field extension operations #159

Merged
merged 44 commits into from
Jan 17, 2025

Conversation

tzerrell
Copy link
Member

@tzerrell tzerrell commented Jan 14, 2025

Add field extension addition, subtraction, and multiplication bigint operations. There are general forms that take a degree parameter and the (non-leading) coefficients of the monic irreducible polynomial of the extensions. Also, for multiplication, there's a specialized version that's more efficient specifically for the extension F[x]/(x^2 + 1).

Generate blobs for 256 bits for degree 2 for all of these, and also for a degree 4 multiplication.

Closes ZKVM-910

@tzerrell tzerrell self-assigned this Jan 14, 2025
@github-actions github-actions bot changed the title Add field extension operations ZIR-325: Add field extension operations Jan 14, 2025
Copy link
Contributor

@mars-risc0 mars-risc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely clean code

@tzerrell tzerrell enabled auto-merge (squash) January 15, 2025 20:54
Copy link

linear bot commented Jan 17, 2025

@github-actions github-actions bot changed the title ZIR-325: Add field extension operations ZKVM-910: ZIR-325: Add field extension operations Jan 17, 2025
@tzerrell tzerrell force-pushed the tzerrell/bigint2-ext-field branch from 712307b to c23e9f9 Compare January 17, 2025 18:11
@tzerrell
Copy link
Member Author

Heads up that I force-rebased the last half dozen or so commits because they hadn't been properly signed. There were no changes though (beyond merging with the latest on main)

@tzerrell tzerrell merged commit 969982e into main Jan 17, 2025
10 checks passed
@tzerrell tzerrell deleted the tzerrell/bigint2-ext-field branch January 17, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants