Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIR-327: make the compiler happy by explicitly value-initializing std::array<>s #161

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mars-risc0
Copy link
Contributor

spotted a warning I hadn't noticed before: even though we always overwrite the contents of these arrays, it doesn't hurt to explicitly initialize them, thereby pacifying the maybe-uninitialized checker.

@github-actions github-actions bot changed the title make the compiler happy by explicitly value-initializing std::array<>s ZIR-327: make the compiler happy by explicitly value-initializing std::array<>s Jan 14, 2025
@mars-risc0 mars-risc0 enabled auto-merge (squash) January 15, 2025 00:12
Copy link
Contributor

@shkoo shkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's an easy way to catch this stuff in CI...

@mars-risc0 mars-risc0 merged commit 14453b9 into main Jan 15, 2025
10 checks passed
@mars-risc0 mars-risc0 deleted the mars/fix-warning-array-initialization branch January 15, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants