ZIR-330: [Picus] Muxes, backs, and more #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
mars-risc0
approved these changes
Jan 17, 2025
| @@ -175,13 +202,6 @@ class PicusPrinter { | |||
| valuesToSignals.insert({pack.getOut(), nullptr}); | |||
| } | |||
|
|
|||
| void visitOp(ExternOp ext) { | |||
There was a problem hiding this comment.
why is this function no longer necessary? I still see a case for ExternOp in the switch above; is there some other overload which is meant to handle ExternOp now?
There was a problem hiding this comment.
I saw that we were doing the same thing for all of the nondeterministic Zll ops, so I lumped them into a common implementation:
// For nondeterministic operations, mark all results as fresh signals.
void visitNondetOp(Operation* op) {
for (Value result : op->getResults()) {
Signal signal = Signal::get(ctx, freshName());
valuesToSignals.insert({result, signal});
}
}
| auto rhs = valuesToSignals.at(alias.getRhs()); | ||
| for (auto [sl, sr] : llvm::zip(flatten(lhs), flatten(rhs))) { | ||
| os << "(assert (= " << sl.str() << " " << sr.str() << "))\n"; | ||
| // If lhs and rhs have the same lifetime, then aliasing them is |
There was a problem hiding this comment.
thank you for this clear explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picus_inlineattribute so the programmer can force inlining in Picus code (necessary forPo2)