HypMap clean-up #284
HypMap clean-up #284
Conversation
src/hyp_map.rs
Outdated
| /// Generic Id names for each of the U-mode mapping slots. | ||
| /// There is no mandated use for each of the slots, and caller can decide to map each of them | ||
| /// readable or writable based on the requirement. | ||
| #[derive(Copy, Clone)] | ||
| pub enum UmodeSlotId { | ||
| A, | ||
| B, | ||
| } |
There was a problem hiding this comment.
should this go in hyp_layout.rs?
There was a problem hiding this comment.
Could go. Thought about it for about 30 seconds. SlotIDs and Slot Addrs are a specific of the implementation. But yeah, I'll move it, would make things cleaner.
| // Maximum number of hardware map regions. | ||
| const MAX_HW_MAP_REGIONS: usize = 32; |
There was a problem hiding this comment.
these regions are that are identity mapped, right? might be more obvious if this were called the "linear map" or "identity map"
There was a problem hiding this comment.
Was future-proofing for #180, and in general other possible identity mapped might require a different structure, and this change was exactly to create a region type for each source.
There was a problem hiding this comment.
Haven't changed this. Let me know if you have strong opinions about this.
Signed-off-by: Gianluca Guida <[email protected]>
Create a new module, hyp_layout and move all the VM-layout definitions there. Signed-off-by: Gianluca Guida <[email protected]>
HypMap region types were originally built to separate the shared (same across all CPUs) and private (per-CPU allocated) regions of the VA space. This definition became obsolete very quickly, and already since the addition of UmodeInput Region it became clear that it's better to have regions specific to the kind of memory, rather than their shared/private nature. Signed-off-by: Gianluca Guida <[email protected]>
glg-rv
force-pushed
the
topic/hypmap_clean
branch
from
f10ac71 to
b88632f
Compare
This PR serves both to clean up my conscience of U-mode PRs leftovers and to prepare HypMap to support virtual mapped stack more easily.
Sharing before the stack patch to gather opinions.
patch1: U-mode Shared Region is renamed to U-mode Input Region, as it is not writable from U-mode.
patch2: All layout const definitions are moved to a new module: hyp_layout.
patch3: Private/Shared regions (per-cpu, global mappings) is untenable as it would complicate the types too much. Rename them for what they are: hwmap regions and umode_elf regions.