Control board named 'ankle_setup_control_board', works with linear motion in range 0-100 [mm], fixed indentation, no more skipping park #706
+156
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
requested changes
Jan 23, 2025
|
Judging from the commits...
...it seems that you have to rebase on top of upstream devel somehow. |
…r motion in range 0-100 [mm], fixed indentation
AntonioViscomi
force-pushed
the
ankle-setup
branch
from
b8d1830 to
cb81c3d
Compare
Thanks for pointing this out to me. I think I mistakenly rebased on top of master. It should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the joint interprets setpoints as linear displacements within the range [-100, 0] mm, providing a more intuitive representation of motion.
To improve clarity, the control board has been renamed to
ankle_setup_control_board.Additionally, the joint parks correctly when exiting the
yarprobotinterface, as shown in the debug logs:[DEBUG] ankleSetupCalib : Moving to park position, joint: 0 [DEBUG] ankle-setup-calibrator finished park device ankle-setup-mc_remapper