allow changing cropped image mime type #762
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
Id like to be able to crop images using the image upload as described here: https://mary-ui.com/docs/components/file#image-crop
with the current setup, i believe this always generates
image/png
versions of the image by default. I would like to be able to generateimage/jpeg
versions,The cropperjs docs indicate we can change the mime type here - im not sure how you would want to approach the custom choice here in the File component. (https://github.com/fengyuanchen/cropperjs/blob/main/README.md#getcroppedcanvasoptions)
with this change, the user can set the mime type as follows
<x-file wire:model="photo" accept="image/png" crop-after-change cropMimeType="image/jpeg">
resolves #761