Remove references to Task and CalledVia::BangSuffix

roc-lang · Jan 16, 2025 · bbe2d7c · bbe2d7c
1 parent 406cc6c
commit bbe2d7c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/crates/cli/src/format.rs b/crates/cli/src/format.rs
@@ -566,13 +566,13 @@ main =
         let before = HEADER.to_string()
             + indoc! {r#"
             main =
-                Task.ok {}"#};
+                "Hello, World!""#};
 
         let after = HEADER.to_string()
             + indoc! {r#"
-            main : Task {} *
+            main : Str
             main =
-                Task.ok {}
+                "Hello, World!"
             "#};
 
         let annotated = annotate_string(before);
@@ -593,16 +593,16 @@ main =
     fn test_annotate_destructure() {
         let before = HEADER.to_string()
             + indoc! {r#"
-            {a, b} = {a: Task.ok {}, b: (1, 2)}
+            {a, b} = {a: "zero", b: (1, 2)}
 
             main = a"#};
 
         let after = HEADER.to_string()
             + indoc! {r#"
-            {a, b} : { a : Task {} *, b : ( Num *, Num * )* }
-            {a, b} = {a: Task.ok {}, b: (1, 2)}
+            {a, b} : { a : Str, b : ( Num *, Num * )* }
+            {a, b} = {a: "zero", b: (1, 2)}
 
-            main : Task {} *
+            main : Str
             main = a
             "#};
 

diff --git a/crates/language_server/src/analysis/annotation_visitor.rs b/crates/language_server/src/analysis/annotation_visitor.rs
@@ -92,8 +92,7 @@ pub fn find_declaration_at(
 
         fn visit_expr(&mut self, expr: &Expr, region: Region, var: Variable) {
             if self.should_visit(region) {
-                if let Expr::Call(_, args, CalledVia::BangSuffix | CalledVia::QuestionSuffix) = expr
-                {
+                if let Expr::Call(_, args, CalledVia::QuestionSuffix) = expr {
                     let Expr::Closure(ClosureData { arguments, .. }) = &args[1].1.value else {
                         internal_error!("Suffixed expression did not contain a closure")
                     };

diff --git a/crates/language_server/src/server.rs b/crates/language_server/src/server.rs
@@ -687,7 +687,7 @@ mod tests {
     #[tokio::test]
     async fn test_annotate_single() {
         let edit = code_action_edits(
-            DOC_LIT.to_string() + "main = Task.ok {}",
+            DOC_LIT.to_string() + r#"main = "Hello, world!""#,
             Position::new(3, 2),
             "Add signature",
         )
@@ -706,7 +706,7 @@ mod tests {
                             character: 0,
                         },
                     },
-                    new_text: "main : Task {} *\n",
+                    new_text: "main : Str\n",
                 },
             ]
         "#]]
@@ -719,7 +719,7 @@ mod tests {
             DOC_LIT.to_string()
                 + indoc! {r#"
                 other = \_ ->
-                    Task.ok {}
+                    "Something else?"
 
                 main =
                     other {}
@@ -742,7 +742,7 @@ mod tests {
                             character: 0,
                         },
                     },
-                    new_text: "other : * -> Task {} *\n",
+                    new_text: "other : * -> Str\n",
                 },
                 TextEdit {
                     range: Range {
@@ -755,7 +755,7 @@ mod tests {
                             character: 0,
                         },
                     },
-                    new_text: "main : Task {} *\n",
+                    new_text: "main : Str\n",
                 },
             ]
         "#]]