Introduce proper type for TypeVar's, mark anything not a lowercase ident as malformed #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewilliamboswell
previously approved these changes
Jan 14, 2025
crates/compiler/fmt/src/expr.rs
Outdated
Comment on lines
1410
to
1429
| // fn pattern_prec(pat: Pattern<'_>) -> Prec { | ||
| // match pat { | ||
| // Pattern::Identifier { .. } | ||
| // | Pattern::QualifiedIdentifier { .. } | ||
| // | Pattern::Tag(_) | ||
| // | Pattern::OpaqueRef(_) | ||
| // | Pattern::RecordDestructure(..) | ||
| // | Pattern::RequiredField(_, _) | ||
| // | Pattern::OptionalField(_, _) | ||
| // | Pattern::NumLiteral(_) | ||
| // | Pattern::NonBase10Literal { .. } | ||
| // | Pattern::FloatLiteral(_) | ||
| // | Pattern::StrLiteral(..) | ||
| // | Pattern::Underscore(_) | ||
| // | Pattern::SingleQuote(_) | ||
| // | Pattern::Tuple(..) | ||
| // | Pattern::List(..) | ||
| // | Pattern::ListRest(_) | ||
| // | Pattern::PncApply(_, _) => Prec::Term, | ||
| // Pattern::Apply(_, _) | Pattern::As(_, _) => Prec::Apply, |
There was a problem hiding this comment.
Was this meant to be removed?
There was a problem hiding this comment.
Yes, whoops. Will fix.
joshuawarner32
force-pushed
the
TypeVar
branch
from
1344760 to
d43ad92
Compare
lukewilliamboswell
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.