vizkit bugfixes #48
vizkit bugfixes #48
Conversation
| @@ -324,7 +324,7 @@ def push_transformer_configuration(data) | |||
| def listen_to_transformation_producer(trsf) | |||
| return if @connected_transformation_producers.has_key?(trsf.producer) | |||
|
|
|||
| task, *port = trsf.producer.split('.') | |||
| task, bla, *port = trsf.producer.rpartition('.') | |||
There was a problem hiding this comment.
What in your case is bla ?, is it not related to the hostname during replay?
There was a problem hiding this comment.
I did not check replays ... but in the other tests bla is just "."
There was a problem hiding this comment.
Maybe we should:
- rename bla to sep for separator
- change *port to port
- remove line 328.
Other than that the fix solves the problem 👍
There was a problem hiding this comment.
The Ruby idiom for "just ignore this value" is the underscore character
task, _, *port = trsf.producer.rpartition('.')
|
The problem is that qt ruby names all Qt objects Qt::Xyz instead of QXyz (Qt::Widget vs. QWidget) therefore the leading Q must be removed. Unfortunately, this is not the case for plugins like qwt. |
|
And what's your recommendation for this PR then in the end? ok?, howto rework? |
|
You simply have to check if name[1..-1] starts with a capital letter before using const_defined? Maybe checking for the size would not be such a bad idea as well ;-). |
|
@dettmann can you add D-Alex suggestions? |
|
...anbd doudou's |
No description provided.