Explicitly detail the recommendations for the rock-ons root share (#340) #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillxnet
requested changes
Dec 12, 2021
There was a problem hiding this comment.
@FroggyFlox Well done. And nice re-arrangement / enhancement.
I've only got the two word subtraction suggestions indicated. See what you think?
Either way let me know and we can get this out toot sweet.
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
phillxnet
approved these changes
Dec 12, 2021
There was a problem hiding this comment.
@FroggyFlox Thanks. That's super. I'll merge and get this in production.
|
PR product published. |
|
Linking back to a pending doc issue re the rock-ons-root #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
@phillxnet, ready for review.
This pull request's proposal
This pull request proposes to slightly improve the recommendations on the creation of the Rock-ons root share to improve clarity. It essentially:
Checklist