Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native-agent code #324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove native-agent code #324

wants to merge 3 commits into from

Conversation

brianr
Copy link
Member

@brianr brianr commented Jan 13, 2025

Description of the change

The native-agent directory in this repo contains a proof of concept implementation for gathering local variables from the JVM to attach to the stack trace. This feature wasn't completed and hasn't been in active development in some time, and has since accumulated some security advisories. We hope to continue development in the future, and in the meantime, are removing the code from the main branch.

Reverts https://github.com/rollbar/rollbar-java/pull/169/files#diff-4dfc3a2ac68fe45bbeca66ab48fe1598875545c79494d91dd5d509d7df6c52ef

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Fixes:

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

(cherry picked from commit d2e7b2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants