Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby ported to nim #158

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Groupby ported to nim #158

merged 3 commits into from
Apr 5, 2024

Conversation

omenSi
Copy link
Collaborator

@omenSi omenSi commented Apr 5, 2024

No description provided.

@omenSi omenSi requested a review from realratchet April 5, 2024 07:10
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 82.49%. Comparing base (ab32d28) to head (f11cc68).

Files Patch % Lines
tablite/pivots.py 53.33% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   82.98%   82.49%   -0.49%     
==========================================
  Files          27       26       -1     
  Lines        4072     3884     -188     
==========================================
- Hits         3379     3204     -175     
+ Misses        693      680      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@realratchet realratchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it, although we might want to change .toFloat() in the future since it's now used in few places.

@omenSi omenSi merged commit d5cd0de into root-11:master Apr 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants