Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation career section #910

Merged
merged 10 commits into from
Jan 17, 2025
Merged

Spanish translation career section #910

merged 10 commits into from
Jan 17, 2025

Conversation

yabellini
Copy link
Member

No description provided.

content/careers/_index.es.md Outdated Show resolved Hide resolved
content/careers/_index.es.md Outdated Show resolved Hide resolved
content/careers/_index.es.md Outdated Show resolved Hide resolved
content/careers/_index.es.md Outdated Show resolved Hide resolved
content/careers/_index.es.md Outdated Show resolved Hide resolved
content/careers/_index.es.md Outdated Show resolved Hide resolved
@yabellini
Copy link
Member Author

@maelle let me know if I can merge. Just to be sure, I can't go ahead without translating the file mentioned in partials.

@maelle
Copy link
Member

maelle commented Jan 17, 2025

I'll have to make a test with a job add. I will also need to translate the "we are hiring" sentence for the navbar.

@maelle maelle marked this pull request as draft January 17, 2025 10:53
@maelle
Copy link
Member

maelle commented Jan 17, 2025

@yabellini I made a local test with job ads.

The navbar correctly links to the careers section in the right language if it exists.

Could you please help me translate

  • Careers
  • We are hiring
    ?

@maelle maelle marked this pull request as ready for review January 17, 2025 13:37
@maelle maelle merged commit 0f47c12 into main Jan 17, 2025
4 checks passed
steffilazerte pushed a commit that referenced this pull request Jan 20, 2025
* Spanish translation career section

* Apply suggestions from code review

* Apply suggestions from code review

* more localization

* Use translated page in navbar if possible

* more

* traduce

* more

---------

Co-authored-by: Maëlle Salmon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants