-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use actual position when limiting desired position #1988
Open
saikishor
wants to merge
5
commits into
ros-controls:master
Choose a base branch
from
pal-robotics-forks:use/actual_position/limiting_position
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use actual position when limiting desired position #1988
saikishor
wants to merge
5
commits into
ros-controls:master
from
pal-robotics-forks:use/actual_position/limiting_position
+121
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
christophfroehlich,
DasRoteSkelett,
destogl,
mamueluth,
mhubii,
olivier-stasse and
VX792
January 7, 2025 22:14
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1988 +/- ##
==========================================
- Coverage 89.32% 89.32% -0.01%
==========================================
Files 130 130
Lines 14522 14568 +46
Branches 1258 1259 +1
==========================================
+ Hits 12972 13013 +41
- Misses 1083 1086 +3
- Partials 467 469 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
previously approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this makes sense
saikishor
force-pushed
the
use/actual_position/limiting_position
branch
from
January 12, 2025 00:01
fb38c2e
to
bf41ee1
Compare
Resolved conflicts after #1981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating the joint limits into the resource manager, I discovered that the current joint_limits implementation doesn't consider the actual position when limiting the desired position. This was the case as in ROS 1 too it doesn't use it, but uses the previous command value. I think it would make sense to consider the actual position as well in this scenario