Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URDFs #228

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Nov 9, 2020

No description provided.

@bmagyar bmagyar self-assigned this Nov 9, 2020
@bmagyar bmagyar marked this pull request as draft November 9, 2020 11:20
@bmagyar bmagyar marked this pull request as ready for review November 9, 2020 16:49
@bmagyar bmagyar requested a review from destogl November 9, 2020 16:49
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us discuss the FTS example.
Otherwise I like it.

<param name="lower_limits">-100</param>
<param name="upper_limits">100</param>
</state_interface>
<state_interface name="fx"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have limits here... Especially with FTS is that important since one can easily get measurements outside calibrated range.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss that on the roadmap repo if you don't mind. This PR simply brings the examples we have up to date.

Copy link
Member

@destogl destogl Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<state_interface name="tx"/>
<state_interface name="ty"/>
<state_interface name="tz"/>
<param name="frame_id">kuka_tcp</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<param name="frame_id">kuka_tcp</param>
<param name="frame_id">rrbot_tcp</param>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is directly from the roadmap repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also change there. It doesn't make sense to call this kuka_tcp

Copy link
Member

@destogl destogl Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: ros-controls/roadmap#32

you can change it here or not, as you wish.

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved and we can add changes from ros-controls/roadmap#32 in the next PR. As you prefer.

@bmagyar bmagyar merged commit c47791a into ros-controls:master Nov 11, 2020
destogl pushed a commit to StoglRobotics-forks/ros2_control that referenced this pull request Aug 11, 2022
* docs: 📝 Port over ros2_control GitHub templates

* This first commit is an exact copy. Next commit will be any changes to adapt to ros2_controllers

* docs: 📝 Convert ros2_control references to ros2_controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants