-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URDFs #228
Update URDFs #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us discuss the FTS example.
Otherwise I like it.
<param name="lower_limits">-100</param> | ||
<param name="upper_limits">100</param> | ||
</state_interface> | ||
<state_interface name="fx"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have limits here... Especially with FTS is that important since one can easily get measurements outside calibrated range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is often defined per-axis. see: https://www.ati-ia.com/products/ft/ft_models.aspx?id=Mini45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss that on the roadmap repo if you don't mind. This PR simply brings the examples we have up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. see: ros-controls/roadmap#32
<state_interface name="tx"/> | ||
<state_interface name="ty"/> | ||
<state_interface name="tz"/> | ||
<param name="frame_id">kuka_tcp</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<param name="frame_id">kuka_tcp</param> | |
<param name="frame_id">rrbot_tcp</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is directly from the roadmap repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also change there. It doesn't make sense to call this kuka_tcp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change it here or not, as you wish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved and we can add changes from ros-controls/roadmap#32 in the next PR. As you prefer.
* docs: 📝 Port over ros2_control GitHub templates * This first commit is an exact copy. Next commit will be any changes to adapt to ros2_controllers * docs: 📝 Convert ros2_control references to ros2_controller
No description provided.