Add ar2010 support #396
Closed
Add ar2010 support #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2020 13:43
Made robots use materials from that package so they do not conflict when using multiple arms.
Doomerdinger
force-pushed
the
add-ar2010-support-pub
branch
from
fc04d80 to
7127147
Compare
|
Similar to #395, it appears this model has been constructed such that all Please see my #395 (comment) there. The Could you please remove the Gazebo-isms? As in #395: I'm willing to do it, but I wanted to ask you first. |
|
@gavanderhoorn if you have time, you mentioned you could do what is necessary to bring this up to snuff to get it into the main branch? I've had slim to no time to work on this stuff in quite some time. |
|
I'll try to get to it. Thanks for letting us know @Doomerdinger. |
|
Replacement: #480. Thanks for the initial work @Doomerdinger 👍 |
gavanderhoorn
added a commit
that referenced
this pull request
Mar 23, 2022
Squashed commits: * Added AR2010 support. * ar2010: update minimum CMake version to avoid warnings on Noetic * ar2010: add XML preambles where they were missing * ar2010: tabs to spaces * ar2010: remove Gazebo-isms * ar2010: use correct "no-version" version * ar2010: correctly capitalise series name * ar2010: tests should have variant suffix * ar2010: add note about all joints rotating around Z+ Co-authored-by: Alec Tiefenthal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the AR2010.
Requires #378.