-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motoman GP70L Support #553
Conversation
Add support package for Yaskawa/Motoman GP70L robot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One in-line question.
Something I noticed: the meshes in this PR have the same 'issue' with black parts lacking in contrast as in #535:
the cable is much nicer here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify whether this OPW config was created by you @EricMarcil?
Did you also verify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gavanderhoorn OPW were added by @cjue on PR #493 and #500. I simply used those as a base and updated the values. They have not been verified.
I'm not sure if that it something we want to standardize or not. We can remove the file, if you think it is better not to have them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I welcome the addition of OPW configuration files. I just want to make sure we have validated the configuration and are sure the values are correct.
@gavanderhoorn I started importing model data from our MotoSim software. That already have color, smaller models and model for cables. |
@gavanderhoorn I fixed the motor color by making it dark gray. It took a while because every time I tried making changes with blender I would get strange results. I finally realized that the .dae was actually a text file and edited the color directly in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on Eric's testing
Add support package for Yaskawa/Motoman GP70L robot