Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motoman GP70L Support #553

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

EricMarcil
Copy link
Contributor

Add support package for Yaskawa/Motoman GP70L robot

Add support package for Yaskawa/Motoman GP70L robot
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One in-line question.

Something I noticed: the meshes in this PR have the same 'issue' with black parts lacking in contrast as in #535:

image

the cable is much nicer here though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify whether this OPW config was created by you @EricMarcil?

Did you also verify it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavanderhoorn OPW were added by @cjue on PR #493 and #500. I simply used those as a base and updated the values. They have not been verified.
I'm not sure if that it something we want to standardize or not. We can remove the file, if you think it is better not to have them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I welcome the addition of OPW configuration files. I just want to make sure we have validated the configuration and are sure the values are correct.

@EricMarcil
Copy link
Contributor Author

@gavanderhoorn I started importing model data from our MotoSim software. That already have color, smaller models and model for cables.
I'll try to adjust the color of the motors...

@EricMarcil
Copy link
Contributor Author

@gavanderhoorn I fixed the motor color by making it dark gray. It took a while because every time I tried making changes with blender I would get strange results. I finally realized that the .dae was actually a text file and edited the color directly in it.
image

Copy link
Contributor

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on Eric's testing

@ted-miller ted-miller merged commit 7d9ba47 into ros-industrial:kinetic-devel Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants