Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GoalUpdater docs #621

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Update GoalUpdater docs #621

merged 4 commits into from
Jan 14, 2025

Conversation

tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented Dec 11, 2024 •
edited
Loading

@tonynajjar
Update GoalUpdater docs
4c1feec 
Signed-off-by: Tony Najjar <[email protected]>
SteveMacenski
SteveMacenski requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, 👍

configuration/packages/bt-plugins/decorators/GoalUpdater.rst Outdated Show resolved Hide resolved
@tonynajjar
Update GoalUpdater.rst
239fb87 
Signed-off-by: Tony Najjar <[email protected]>
SteveMacenski
SteveMacenski approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the migration guide too. You can add it under the New BT Nodes[](https://docs.nav2.org/migration/Jazzy.html#new-bt-nodes) section I think (with a small title rename to BT Node Changes)

@SteveMacenski
Copy link
Member

@tonynajjar just add to the migration guide and we should be Good to Go to merge this too

@tonynajjar
Copy link
Contributor Author

Sorry forgot, will do tmrw

@tonynajjar
add migration guide
ccafcea 
Signed-off-by: Tony Najjar <[email protected]>
@tonynajjar
Copy link
Contributor Author

Done

@SteveMacenski SteveMacenski merged commit 90c2e60 into ros-navigation:master Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonynajjar @SteveMacenski