return false if connection timeout

[mikaelarguedas]

adresses partially #32

[mikaelarguedas]

@ros-pull-request-builder retest this please.

[nuclearsandwich]

@ros-pull-request-builder retest this please. 🤞

[truhoang]

Has this been fixed? Still running into the problem in #32

[mikaelarguedas]

No this has not been fixed, this PR is pending as it breaks the tests. I didnt have time to look into why yet so I left this PR pending.

Right now the only workaround is to make sure to not wait for longer than the default connextion timeout and delete the bonds when they disconnect and establish new ones.

Any help in testing and validating this PR is welcome.

Hope this helps

[truhoang]

The following was reported:

False is not true
  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/tmp/catkin_workspace/src/bond_core/test_bond/test/test_callbacks_py.py", line 64, in test_die_in_life_callback
    self.assertTrue(a.wait_until_formed(rospy.Duration(5.0)))
  File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
    raise self.failureException(msg)

Seems like the second condition returned false for this test. Shouldn't it test for:

self.sm.getState().getName() == 'SM.Alive'

or would this not matter?

[moshesamson1]

is there any progress regarding this issue?