Fix is_running behaviour in case of exception in the state #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okalachev
changed the title
|
Thank you for contribution. Merging and will depend on the community to further test. |
130s
added a commit
to 130s/executive_smach
that referenced
this pull request
Jun 13, 2023
Fix is_running behaviour in case of exception in the state
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #47,
StateMachine.is_running()returnsTrueeven if user's state has terminated with an exception.I fixed this for
StateMachineandSequencecontainers.However, I did not fix it for
IteratorandConcurrencecontainers as:IteratorandConcurrencelackis_runningmethod (only_is_runningfield exists).Iteratoris not unit tested at all yet.