Clean rolling CI #82

ahcorde · 2024-06-28T11:21:05Z

No description provided.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

clalancette · 2024-06-28T16:56:50Z

The change looks OK to me, but this is failing because I think

Line 55 in 6481e8f

point_sub_.subscribe(this, "/turtle3/turtle_point_stamped");

needs to be updated to pass in a QoS parameter.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

ahcorde · 2024-07-11T10:25:17Z

@clalancette friendly ping

turtle_tf2_cpp/src/turtle_tf2_message_filter.cpp

Co-authored-by: Chris Lalancette <[email protected]>

clalancette

Looks good to me with green CI.

Clean rolling CI

80e9854

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

ahcorde requested a review from clalancette June 28, 2024 11:21

ahcorde self-assigned this Jun 28, 2024

ahcorde changed the base branch from ros2 to rolling July 1, 2024 08:39

ahcorde added 2 commits July 1, 2024 10:53

Update message filters API

b7a6360

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

make linters happy

00b7741

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

clalancette requested changes Jul 11, 2024

View reviewed changes

turtle_tf2_cpp/src/turtle_tf2_message_filter.cpp Outdated Show resolved Hide resolved

Update turtle_tf2_cpp/src/turtle_tf2_message_filter.cpp

af4539e

Co-authored-by: Chris Lalancette <[email protected]>

ahcorde requested a review from clalancette July 11, 2024 13:17

Merge branch 'rolling' into ahcorde/rolling/clean_ci

bb05465

clalancette approved these changes Jul 11, 2024

View reviewed changes

ahcorde merged commit a3979b4 into rolling Jul 11, 2024
8 of 9 checks passed

ahcorde deleted the ahcorde/rolling/clean_ci branch July 11, 2024 16:06

Provide feedback