Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turtlebot4_setup: 1.0.5-1 in 'humble/distribution.yaml' [bloom] #44188

Closed

Conversation

civerachb-cpr
Copy link
Contributor

Increasing version of package(s) in repository turtlebot4_setup to 1.0.5-1:

turtlebot4_setup

* Remove dhcp true because it was causing eth0 to lose the static IP (#17 <https://github.com/turtlebot/turtlebot4_setup/issues/17>)
* Change the post-install chrony file command from mv to cp. Only copy if the file actually exists.
* Contributors: Chris Iverach-Brereton, Hilary Luo

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Jan 14, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the release branches didn't get pushed to the release repo.

  warning: Could not find remote branch release/humble/turtlebot4_setup/1.0.5-1 to clone.
  fatal: Remote branch release/humble/turtlebot4_setup/1.0.5-1 not found in upstream origin
RuntimeError: humble: missing package.xml file for package "turtlebot4_setup"

I'm not sure what would cause this. Maybe re-running bloom-release will fix it?

@sloretz sloretz added the changes requested Maintainers have asked for changes to the pull request label Jan 14, 2025
@civerachb-cpr
Copy link
Contributor Author

I think when I bloomed it I typed in the wrong release repo push URL. Re-blooming now; I'll open a new MR for that one.

@civerachb-cpr civerachb-cpr deleted the bloom-turtlebot4_setup-3 branch January 14, 2025 18:04
@civerachb-cpr
Copy link
Contributor Author

Re-bloomed: #44190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants