-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for the URDF xsd specification #200
Open
aminya
wants to merge
6
commits into
ros:master
Choose a base branch
from
aminya:xsd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harleylara <[email protected]>
Signed-off-by: harleylara <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
traversaro
reviewed
May 29, 2024
Signed-off-by: Amin Yahyaabadi <[email protected]>
This pull request has been mentioned on ROS Discourse. There might be relevant details there: |
Hi people 😃 ... any update on this ? |
The PR has been ready to get merged! Waiting for someone with access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvements include specifications for:
This builds on top of the XSD changes from #183 and then fixes the remaining XSD issues related to:
The specification can be tested via the following (e.g. in VsCode with the XML extension):
The above code is backward compatible with the parsers as it doesn't add a namespace to the robot tag. If a namespace is added, some parsers like Python's parser add
ns0:
before the tags. Not requiring a namespace makes it possible to verify the XML without changing the tags.