use helper function strToDouble for locale independent parsing of colors

ros · Nov 14, 2018 · f97cbce · f97cbce
1 parent e7e0972
commit f97cbce
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/urdf_model/include/urdf_model/color.h b/urdf_model/include/urdf_model/color.h
@@ -73,13 +73,10 @@ class Color
       {
         try
         {
-          rgba.push_back(std::stof(pieces[i]));
+          rgba.push_back(strToDouble(pieces[i].c_str()));
         }
-        catch (std::invalid_argument &/*e*/) {
-          return false;
-        }
-        catch (std::out_of_range &/*e*/) {
-          return false;
+        catch (std::runtime_error &/*e*/) {
+          throw ParseError("Unable to parse component [" + pieces[i] + "] to a double (while parsing a color value)");
         }
       }
     }