Switch to using fastjsonschema for schema validation. #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason to do this is because jsonschema (what we currently use) depends on referencing, which depends on rpds-py, which has C libraries. That means that when using the python debug interpreter on Windows, we would have to build a custom pip package for it to work. In contrast, fastjsonschema is pure python and has no dependencies. It is also available on all of our default platforms. So switch to using it here so things work on Windows debug. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
|
Rpr job is expected to fail until we actually merge this in and do a release. |
|
CI:
|
fujitatomoya
approved these changes
Jun 11, 2024
|
@ros-pull-request-builder retest this please |
wjwwood
approved these changes
Jun 12, 2024
adityapande-1995
approved these changes
Jun 12, 2024
This was referenced Jun 12, 2024
|
Here's new CI with the new changes in ros2/ci#782 and ros-infrastructure/ros2-cookbooks#71:
|
|
All right, all dependent PRs are merged, and CI is green here. Going ahead and merging this one in, thanks for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason to do this is because jsonschema (what we currently use) depends on referencing, which depends on rpds-py, which has C libraries. That means that when using the python debug interpreter on Windows, we would have to build a custom pip package for it to work.
In contrast, fastjsonschema is pure python and has no dependencies. It is also available on all of our default platforms. So switch to using it here so things work on Windows debug.
Note that this depends on both ros2/ci#782 and ros/rosdistro#41538 to go in first.